Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agents: fix crash in StatsDAgent #32

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

santigimeno
Copy link
Member

With some specific udp send errors, it's not possible to retrieve the peername. Handle this case to avoid crashes.

Fixes: #31

@santigimeno santigimeno self-assigned this Nov 23, 2023
With some specific udp send errors, it's not possible to retrieve the
peername. Handle this case to avoid crashes.

Fixes: #31
PR-URL: #32
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
@santigimeno santigimeno merged commit 5a47d7e into node-v20.x-nsolid-v5.x Dec 1, 2023
15 of 18 checks passed
@santigimeno santigimeno deleted the santi/fix_crash_peername branch December 1, 2023 10:24
santigimeno added a commit that referenced this pull request Dec 6, 2023
With some specific udp send errors, it's not possible to retrieve the
peername. Handle this case to avoid crashes.

Fixes: #31
PR-URL: #32
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
trevnorris pushed a commit that referenced this pull request Dec 7, 2023
With some specific udp send errors, it's not possible to retrieve the
peername. Handle this case to avoid crashes.

Fixes: #31
PR-URL: #32
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on StatsDAgent on resource-constrained box with load
2 participants