src: make nsolid::ThreadMetrics safer #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
force-pushed
the
santi/fix_thread_metrics
branch
from
4062088
to
efca53f
Compare
trevnorris
force-pushed
the
node-v20.x-nsolid-v5.x
branch
from
1a1236e
to
b2c1bb3
Compare
santigimeno
force-pushed
the
santi/fix_thread_metrics
branch
2 times, most recently
from
601cc15
to
8f5c66a
Compare
santigimeno
changed the title
santigimeno
force-pushed
the
santi/fix_thread_metrics
branch
from
8f5c66a
to
ebeff03
Compare
trevnorris
force-pushed
the
node-v20.x-nsolid-v5.x
branch
from
f3399e1
to
12dcf71
Compare
santigimeno
force-pushed
the
santi/fix_thread_metrics
branch
2 times, most recently
from
d41c671
to
0246a12
Compare
trevnorris
approved these changes
Dec 13, 2023
The current ThreadMetrics API is not easy to use safely because the `ThreadMetrics` instance needs to be alive while there is a pending `Update()` callback to be called. Change the API to use shared_ptr, as we define a new type `SharedThreadMetrics` as `std::shared_ptr<ThreadMetrics>`. This is a breaking change but considering previous API was completely unsafe and apparently there're still no consumers I think is a good change. PR-URL: #37 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
santigimeno
force-pushed
the
santi/fix_thread_metrics
branch
from
0246a12
to
a218600
Compare
trevnorris
pushed a commit
that referenced
this pull request
Dec 19, 2023
The current ThreadMetrics API is not easy to use safely because the `ThreadMetrics` instance needs to be alive while there is a pending `Update()` callback to be called. Change the API to use shared_ptr, as we define a new type `SharedThreadMetrics` as `std::shared_ptr<ThreadMetrics>`. This is a breaking change but considering previous API was completely unsafe and apparently there're still no consumers I think is a good change. PR-URL: #37 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
trevnorris
pushed a commit
that referenced
this pull request
Dec 19, 2023
The current ThreadMetrics API is not easy to use safely because the `ThreadMetrics` instance needs to be alive while there is a pending `Update()` callback to be called. Change the API to use shared_ptr, as we define a new type `SharedThreadMetrics` as `std::shared_ptr<ThreadMetrics>`. This is a breaking change but considering previous API was completely unsafe and apparently there're still no consumers I think is a good change. PR-URL: #37 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ThreadMetrics API is not easy to use safely because the
ThreadMetricsinstance needs to be alive while there is a pendingUpdate()callback to be called. Change the API to use shared_ptr, as we define a new typeSharedThreadMetricsasstd::shared_ptr<ThreadMetrics>.This is a breaking change but considering previous API was completely
unsafe and apparently there're still no consumers I think is a good
change.