chore(package): update mocha to version 4.0.1 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kind of curious how the build hangs after all tests pass. Seeing same behavior with noflo/noflo-runtime-websocket#77 @jonnor ideas? |
|
@bergie Mocha 4 will no longer forcefully stop the tests when done. So any nodejs thing still active will keep it hanging. Mentioned in its changelog |
|
@jonnor ok, so the issue is that we have some MQTT/AMQP connections left hanging or somesuch? |
|
Yes or any other deferred thing, like a setInterval. msgflo-nodejs is happy with Mocha 4 though. Probably need to check with one of the Nodejs debugging tools for this kind of problem |
|
Here is a way to see what's hanging: https://stackoverflow.com/a/32617487/263570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #207