Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add option to ignore exceptions #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

automata
Copy link
Member

Shows exceptions, dump a trace but do not exit process if option is true. As suggested.

I should add that on other PR, too late. Sorry.

Shows exceptions, dump a trace but do not exit process
if option is true.
@automata automata changed the title Add option to ignore exceptions WIP: Add option to ignore exceptions Nov 24, 2015
@jonnor
Copy link
Member

jonnor commented Nov 24, 2015

@automata I don't think this specificially needs an automated test. Just run with & without the --ignore-exceptions option and verify it does the right thing.

But if you'd like to add something for the exception catching, can do that in https://github.com/noflo/noflo-runtime-msgflo/blob/master/spec/tracing.coffee - need to add some NoFo component + graph which allows to cause exception.

@automata
Copy link
Member Author

@jonnor added a simple test, can be extended to other options as well. Just saw your comment now, can remove the test by rebase if needed.

@jonnor
Copy link
Member

jonnor commented Nov 24, 2015

Parse test is fine, though generally I don't care much for unit tests. But if you're gonna have that, at least also have a test for when option does not exist.

@automata
Copy link
Member Author

Right, gonna go deep in this hole later. Do not merge, please. Back into debugging caliper now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants