Fix infinite recursion in swagger.py for circular models #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any update on this? i ran into the same bug. This PR fixes it. |
|
Thank you for contributing. Please add relevant tests to cover the issue. |
|
I'm waiting for @Drarok to merge new test in his branch. It will fix the coverage issue. |
|
@buggyspace it’s a two line change, and I’m not even sure how I would begin to test for the failure case. |
Drarok
force-pushed
the
fix/infinite-recursion-bug
branch
from
fd8358a to
cd26463
Compare
|
@buggyspace oh, amazing! Thank you! For some reason I didn't get a notification about that. I've brought your commit over and rebased on current master, so we should be good to go? |
|
Any news on merging this, guys? I think circular model reference for api doc is pretty usual thing occuring from time to time in any project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With thanks to @edwardfung123 from Dec 2016 for identifying this fix, fixes #190.