deployment fixes #44
Open
deployment fixes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwidera
approved these changes
Jun 16, 2022
Comment on lines
+1
to
+4
| const BackendURL = | ||
| 'https://monkfish-app-i4ovz.ondigitalocean.app/docker-backend/mortgageCalculator'; | ||
| const wiborChartURL = | ||
| 'https://monkfish-app-i4ovz.ondigitalocean.app/docker-backend/wiborChart'; |
There was a problem hiding this comment.
I'm not quite sure whether this is a correct way to hardcode URL for frontend endpoints for DigitalOcean
I guess looking at a documentation my suggestion here would be to introduce it as a docker image environment variable: https://docs.digitalocean.com/products/app-platform/how-to/use-environment-variables/
But as long as it works it's fine with me, and you can ignore this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes and changes in preparation for Digital Ocean deployment