Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Link for NPUs #455

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Display Link for NPUs #455

merged 2 commits into from
Feb 21, 2025

Conversation

nokyan
Copy link
Owner

@nokyan nokyan commented Feb 21, 2025

No description provided.

@nokyan nokyan merged commit 4360abf into main Feb 21, 2025
2 checks passed
@nokyan nokyan deleted the link-npu branch February 21, 2025 09:01
@peterdk
Copy link
Contributor

peterdk commented Feb 22, 2025

So, am I right that now GPU and Drive does not refresh link data on each refresh? Cause GPU dynamically changes link speed every second or so, Going from PCIe 1.0 in idle to PCIe 4.0 when fully loaded. That's interesting info to keep seeing. For drives that's a bit less the case, but I would prefer to keep those dynamically updated. As long as the slot info is not updated every time I don't see a lot of issue with performance.

@nokyan
Copy link
Owner Author

nokyan commented Feb 22, 2025

So, am I right that now GPU and Drive does not refresh link data on each refresh? Cause GPU dynamically changes link speed every second or so, Going from PCIe 1.0 in idle to PCIe 4.0 when fully loaded. That's interesting info to keep seeing. For drives that's a bit less the case, but I would prefer to keep those dynamically updated. As long as the slot info is not updated every time I don't see a lot of issue with performance.

Oh, I wasn't aware of that. I'll revert that change then. :)

@peterdk
Copy link
Contributor

peterdk commented Feb 22, 2025

Ah great. :) And nice adding the NPU one! Love that we can just simply pass the PcieSlot and get our data.

@nokyan
Copy link
Owner Author

nokyan commented Feb 22, 2025

Love that we can just simply pass the PcieSlot and get our data.

Yeah, that's really neat!

Do you mind checking out the update-links branch to see if everything works correctly again?

@peterdk
Copy link
Contributor

peterdk commented Feb 22, 2025

@nokyan Looks good. I tested it and my videocard indeed now changes speeds. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants