Open
Conversation
Jan200101
force-pushed
the
PR/0.15.2
branch
5 times, most recently
from
291f51a to
df8999e
Compare
Contributor
Author
|
Compiles and tested against various test files but pytest fails with |
Contributor
Author
|
the JSON-RPC errors in the pytest run seem to appear from 1.7.0 onwards so its not inherent to the 0.15.2 upgrade. |
Contributor
Author
|
figured it out, addressed in #84 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #82
Tested using the glsl_analyzer vscode extension and a test file that contained common operations, its possible that something is missing here that I didn't encounter.