Open
Conversation
nolanderc
requested changes
Oct 22, 2025
Owner
nolanderc
left a comment
nolanderc
left a comment
There was a problem hiding this comment.
Thanks a lot, and great work for your first time in Zig!
I might spend some time testing how well this works in VSCode and neovim as well before merging.
src/main.zig
Outdated
Comment on lines
+416
to
+422
| var tree = parse.parse(self.allocator, document.source(), .{ | ||
| .diagnostics = &parse_diagnostics, | ||
| }) catch |err| { | ||
| std.log.warn("failed to re-parse for diagnostics: {}", .{err}); | ||
| return; | ||
| }; | ||
| defer tree.deinit(self.allocator); |
Owner
There was a problem hiding this comment.
See if you can use the Document.parseTree function here instead. It caches the parsed tree, so that we don't have to redo the parsing next time the document is used (such as when triggering completions).
Owner
|
Did not mean to perform that merge into your branch, sorry about that :( |
Author
|
All good! Sorry for the delay, I'll make the changes this week |
|
Tested on Mac compiled with zig 0.14.1 and this fixes neovim diagnostics for glsl code. I reccomend that you merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish diagnostics to the frontend. I've never programmed Zig before so let me know if I did anything heinous here. Also did have Claude help me here so might be a bit sloppy. I cleaned up the major issues I saw it produce (e.g. parsing the tree multiple times in a row to publish the diagnostics). Was thinking of just having the Notification just be a specialized
id: nullfield of Request but that appears to be discouraged by the spec.This should resolve issue 63. I did see you mention a queueing system for the notifs that I didn't get around to implementing. Let me know if that's necessary
What it looks like in Emacs:
