Apply ruff

[ndaelman-hu]

No description provided.

[ndaelman-hu]

So, 1 question is about the pycodestyle and pylint dependencies: can these dependencies be removed with ruff present?

[blueraft]

So, 1 question is about the pycodestyle and pylint dependencies: can these dependencies be removed with ruff present?

Yes, they should be removed. You can remove the pycodestyle and pylint step in the workflow file too.

Currently the workflow file only has a ruff lint check but no format check so you might want to add one for that too. This can be added the following way:
https://github.com/nomad-coe/nomad-parser-example/blob/2bd4d49996b3d300c87d2225c5433c41e8eb7ce7/.github/workflows/actions.yaml#L49C1-L55C29

Folks at astral are working on having a unified command for both lint and format but it's not done yet - astral-sh/ruff#8232.

[ndaelman-hu]

So, 1 question is about the pycodestyle and pylint dependencies: can these dependencies be removed with ruff present?

Yes, they should be removed. You can remove the pycodestyle and pylint step in the workflow file too.

Currently the workflow file only has a ruff lint check but no format check so you might want to add one for that too. This can be added the following way: https://github.com/nomad-coe/nomad-parser-example/blob/2bd4d49996b3d300c87d2225c5433c41e8eb7ce7/.github/workflows/actions.yaml#L49C1-L55C29

Folks at astral are working on having a unified command for both lint and format but it's not done yet - astral-sh/ruff#8232.

In the link you provided, ruff formatting is still commented out, though...

[blueraft]

So, 1 question is about the pycodestyle and pylint dependencies: can these dependencies be removed with ruff present?

Yes, they should be removed. You can remove the pycodestyle and pylint step in the workflow file too.
Currently the workflow file only has a ruff lint check but no format check so you might want to add one for that too. This can be added the following way: https://github.com/nomad-coe/nomad-parser-example/blob/2bd4d49996b3d300c87d2225c5433c41e8eb7ce7/.github/workflows/actions.yaml#L49C1-L55C29
Folks at astral are working on having a unified command for both lint and format but it's not done yet - astral-sh/ruff#8232.

In the link you provided, ruff formatting is still commented out, though...

Yeah 😅. Markus wanted auto-formatting to be optional in the example templates, but we are opting-in to auto-format code in this repo.

[ndaelman-hu]

@ladinesa If this fixes the pipeline, then we should consider adding merge checks again, i.e. you can only merge when passing the pipeline.
I would also split the build test from the python tests...

[blueraft]

LGTM from my side, you can also remove the pylintrc file.

[ndaelman-hu]

LGTM from my side, you can also remove the pylintrc file.

Applied it in a separate merge.