Calculate supply in REST #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
freak12techno
commented
Feb 24, 2024
freak12techno
commented
- add query for app to calculate supply
- use this query in nom supply endpoint
- add new endpoint to return supply on all denoms to return nom supply there (need to add BTC supply there as well, will probably add it in another PR)
freak12techno
commented
Feb 24, 2024
src/app.rs
Outdated
| let community_pool_rewards_minted: u64 = self.community_pool_rewards.amount_minted.into(); | ||
| let incentive_pool_rewards_minted: u64 = self.incentive_pool_rewards.amount_minted.into(); | ||
|
|
||
| Ok(Amount::new(initial_supply + staking_rewards_minted + dev_rewards_minted + community_pool_rewards_minted + incentive_pool_rewards_minted)) |
There was a problem hiding this comment.
Need someone to review this part and verify this is how total supply is calculated on cosmos-sdk, not sure if cosmos-sdk considers all of these values or not
|
Sorry for the delay - looks like this just needs |
|
@mappum you may try squash + merging this btw, to have 1 commit on main instead of 4 after merging |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #285 +/- ##
========================================
Coverage 36.84% 36.84%
========================================
Files 25 25
Lines 9459 9459
========================================
Hits 3485 3485
Misses 5974 5974 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.