Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mp3 support #2

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Add mp3 support #2

merged 5 commits into from
Jun 18, 2024

Conversation

magnus-nomono
Copy link

This adds mp3 support and also some other small changes to fully integrate this build of ffmpeg into our workflows.

@magnus-nomono magnus-nomono requested a review from iver56 June 17, 2024 13:34
common.sh Outdated Show resolved Hide resolved
Copy link

@iver56 iver56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is there anything related to dash that we can/should disable? And what about caf export?

@magnus-nomono
Copy link
Author

LGTM! Is there anything related to dash that we can/should disable? And what about caf export?

dash was part of webm, which is removed. Caf was never added (except for some local testing I did)

@magnus-nomono magnus-nomono reopened this Jun 18, 2024
@magnus-nomono magnus-nomono merged commit 7de38d6 into 5.1 Jun 18, 2024
9 checks passed
@magnus-nomono magnus-nomono deleted the mbk/add_mp3_support branch June 18, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants