fix: send output_enter in wlr-foreign-toplevel protocol#89
Merged
Conversation
Taskbars like Waybar filter toplevels by output. Without output_enter events, they never display any windows. Send output_enter when a toplevel is mapped and when a late-joining manager binds.
Taskbars like Waybar filter toplevels by output. Without output_enter events, they never display any windows. - Send output_enter in the same batch as initial properties (before done) - Store per-toplevel output so late-joining managers get the correct one - Reuse target_output instead of recomputing the output lookup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wlr/taskbarmodule filters toplevels by output — withoutoutput_enterevents, no windows are displayedoutput_enterwhen a toplevel is first mapped (resolves the correctwl_outputper-client)output_enterfor existing toplevels when a new manager binds (late-joining Waybar)send_output_enter/send_output_leaveto bothWlrForeignToplevelHandleandForeignToplevelHandlesfixes #88
Test plan
wlr/taskbarmodule, open windows — they should appear in the taskbar