Skip to content

[Backport into 5.18] bucket notifications - connect mount should be unique (#1514) #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2025
Merged

[Backport into 5.18] bucket notifications - connect mount should be unique (#1514) #1515

merged 2 commits into from
Jan 29, 2025

Conversation

alphaprinz
Copy link
Contributor

@alphaprinz alphaprinz commented Jan 28, 2025 •
edited
Loading

@alphaprinz alphaprinz changed the title [Backport into 5.18[ bucket notifications - connect mount should be unique (#1514) [Backport into 5.18] bucket notifications - connect mount should be unique (#1514) Jan 28, 2025
@alphaprinz alphaprinz force-pushed the notif_backports branch 4 times, most recently from dea63a9 to 46a35ca Compare January 29, 2025 03:57
@alphaprinz alphaprinz requested a review from liranmauda January 29, 2025 04:48
@alphaprinz alphaprinz marked this pull request as draft January 29, 2025 04:48
@alphaprinz alphaprinz requested a review from dannyzaken January 29, 2025 05:10
alphaprinz and others added 2 commits January 29, 2025 08:01
@alphaprinz
bucket notifications - connect mount should be unique (noobaa#1514)
337f06f 
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
@zregvart @alphaprinz
Also install setuptools
6761c74 
Without setuptools, running operator-courier fails with:

```
Traceback (most recent call last):
  File "/Users/zregvart/work/croz/noobaa/noobaa-operator/build/_output/venv/bin/operator-courier", line 5, in <module>
    from operatorcourier.cli import main
  File "/Users/zregvart/work/croz/noobaa/noobaa-operator/build/_output/venv/lib/python3.13/site-packages/operatorcourier/cli.py", line 2, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
make: *** [gen-olm] Error 1
```

Signed-off-by: Zoran Regvart <zoran@regvart.com>
@alphaprinz alphaprinz marked this pull request as ready for review January 29, 2025 16:03
@nimrod-becker nimrod-becker merged commit 6695191 into noobaa:5.18 Jan 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda Awaiting requested review from liranmauda

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alphaprinz @nimrod-becker @zregvart