Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting the rts pin to false when the dtr pin is used to reset boards. #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tocalvo
Copy link
Contributor

@tocalvo tocalvo commented May 16, 2017

Hi! I'm adding the Freaks Car (http://www.elecfreaks.com/estore/freakscar-robot-starter-kit-741.html) to Bitbloq ( our robot/boards family is growing 😄 )

But when i try to program it with avrGirl always give me a timeout, i was searching and it's because the board never resets on the flashing process.
I see that the reset is done in avrgir setting the DTR and RTS pins to true.
But setting DTR to true, and RTS to false it works.
I try with a bqZum and with an Arduino UNO, and works too. So i created the pull request because looks good.
Buuut I'm not sure if this change can affect to more boards, i'm searching more info about the reset process on Arduino, but only see information about the DTR pin, never about the RTS, i'm not sure if is used too.
Can you test it in the other boards? if you find some board with errors setting the RTS to false, i can change the pull request to add a RTS option in the boards.json to handle this case in the reset.

Thanks!

@coveralls
Copy link

coveralls commented May 16, 2017

Coverage Status

Coverage remained the same at 44.118% when pulling 9071b07 on tocalvo:avoid-rts-on-board-reset into 8b8a67b on noopkat:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.118% when pulling 9071b07 on tocalvo:avoid-rts-on-board-reset into 8b8a67b on noopkat:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.118% when pulling 9071b07 on tocalvo:avoid-rts-on-board-reset into 8b8a67b on noopkat:master.

@noopkat
Copy link
Owner

noopkat commented May 17, 2017

Hi @tocalvo!

Thanks for this pull request. I'll test this on all operating systems and with all the boards I have and let you know. Won't get to this until the weekend, apologies.

I also aim to look at your stk500v1 pull request also, apologies for the lag! I've had a tonne of travel the last month 🙇‍♀️

@noopkat noopkat self-requested a review May 17, 2017 22:55
@noopkat
Copy link
Owner

noopkat commented May 21, 2017

just an update - I tested 90% of the boards on macOS and they're great. I'll now test on Windows and Linux but it's looking good so far!

@tocalvo
Copy link
Contributor Author

tocalvo commented May 21, 2017

Thank you so much for your time and patience!! 😄
I'll wait, no problem. If i can help you in any way, just tell me.

@nandub
Copy link
Contributor

nandub commented Jun 15, 2018

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants