Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from jitsi:master #36

Open
wants to merge 169 commits into
base: master
Choose a base branch
from
Open

[pull] master from jitsi:master #36

wants to merge 169 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Mar 18, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

bgrozev and others added 4 commits March 15, 2023 10:29
A bump to 2.2 was intended with the mono repo changes, but it was only
partially done (a v2.2 tag exists, but pom.xml still lists 2.1).
…2003)

* feat: Support setting the initial value of last-n through colibri2.

* fix: initial-last-n only has effect before constraints are received.

* chore: Update jitsi-xmpp-extensions.
* Move SctpHandler and DataChannelHandler out of Endpoint.

* Add datachannel support for relay message transport.

* Put sctp in transport response if it was in the request.

* Update docs to mention that relays can use SCTP.

* Don't advertise websockets for relay connections if told to use data channels in the signaling.

* Fix typo in exception message.
@pull pull bot added the ⤵️ pull label Mar 18, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 7.01% and project coverage change: -0.12 ⚠️

Comparison is base (1c5748a) 43.14% compared to head (7a3271b) 43.03%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #36      +/-   ##
============================================
- Coverage     43.14%   43.03%   -0.12%     
- Complexity     1675     1677       +2     
============================================
  Files           323      325       +2     
  Lines         16740    16888     +148     
  Branches       2202     2227      +25     
============================================
+ Hits           7222     7267      +45     
- Misses         8808     8910     +102     
- Partials        710      711       +1     
Impacted Files Coverage Δ
...n/java/org/jitsi/videobridge/sctp/SctpManager.java 0.00% <0.00%> (ø)
.../src/main/kotlin/org/jitsi/videobridge/Endpoint.kt 20.50% <0.00%> (+0.03%) ⬆️
.../videobridge/colibri2/Colibri2ConferenceHandler.kt 1.16% <0.00%> (-0.11%) ⬇️
...g/jitsi/videobridge/relay/RelayMessageTransport.kt 7.92% <4.76%> (-1.18%) ⬇️
...c/main/kotlin/org/jitsi/videobridge/relay/Relay.kt 16.63% <7.00%> (-1.40%) ⬇️
...n/org/jitsi/videobridge/sctp/DataChannelHandler.kt 12.50% <12.50%> (ø)
...n/kotlin/org/jitsi/videobridge/sctp/SctpHandler.kt 17.39% <17.39%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

JonathanLennox and others added 24 commits March 20, 2023 11:57
…n endpoint error (#1999)

* Added functionality to send back UNKNOWN_ENDPOINT Colibri2Error when there is no such endpoint. This addition reason will help jicofo to recognise this colibri2 error and re-invite participant instead of invalidating whole bridge and re-inviting all participants.

* ref: Move UnknownEndpointException definition.

* Update jitsi-xmpp-extensions.

* feat: Return feature_not_implemented for colibri2 requests

that use features known not to be properly supported by jitsi-videobridge
(and not used in jicofo). This is mostly to help spot problems early if
developing a different colibri2 client (not jicofo).

* feat: Suppress UNKNOWN_ENDPOINT errors for some requests

When the request is just trying to expire and endpoint or relay that is
missing (presumably already expired) we don't need to throw an error.
Same if the request only updates the force-mute state of an endpoint
(the only other operation that is currently performed in a batch by
jicofo).

Other requests, which create an endpoint/relay or update the
media/sources/transport of an endpoint still throw UNKNOWN_ENDPOINT
erorrs. These requests are now required to reference a single endpoint
or relay (to simplify error handling).

---------

Co-authored-by: Boris Grozev <boris@jitsi.org>
* Put assumed-bandwidth-bps behind a config flag.
…ints. (#2010)

* Call conference.addEndpoints() a single time when adding RelayedEndpoints.
Even if it has no participants - it might be bridging to a visitor relay.
* Add meshId to debug state.
* Add stats for packet/byte count organized by conference size.
* Update to Jetty 11.0.14.

(Including jicoco dependency.)

* Bump jicoco, and jersey version.

This also necessitated bumping junit and kotest versions for tests, and fixing one test syntax.

* Exclude some spotbugs errors from new kotest.

* Pull in the correct junit-jupiter-api version.

* Fix some deprecated kotest API usages.
* Remove unnecessary try/catch.

* Actually return health check result.
)

This fixes inter-relay bridge channels when SCTP datachannels are disabled.
…ot send for screensharing. (#2017)

* fix: Fix sending preemptive keyframe requests with source names, do not send for screensharing.
Fixes finding the AudioSourceDesc when it belongs to a RelayedEndpoint.
The Relay already has its ID in the context resulting in:
relayId=jvb-foo-bar relay-id=jvb-foo-bar
or suspiciously high, or the sender's "delay since last SR" values is
too high.
Disable some rules that are annoying.

Corresponding code format changes (should be no substantive change).
bgrozev and others added 30 commits June 10, 2024 07:40
…urable timeline. (#2163)

* feat(stats): Count iceTransport.send as part of transit time.
* feat(config): Make the packet timeline configurable.

* ref: Make PacketInfo.timeline nullable.
* fix: Make the packet timeline thread safe.
* chore(deps): Bump bouncycastle.version from 1.77 to 1.78.1

Bumps `bouncycastle.version` from 1.77 to 1.78.1.

Updates `org.bouncycastle:bctls-jdk18on` from 1.77 to 1.78.1
- [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

Updates `org.bouncycastle:bcprov-jdk18on` from 1.77 to 1.78.1
- [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

Updates `org.bouncycastle:bcpkix-jdk18on` from 1.77 to 1.78.1
- [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

---
updated-dependencies:
- dependency-name: org.bouncycastle:bctls-jdk18on
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.bouncycastle:bcprov-jdk18on
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.bouncycastle:bcpkix-jdk18on
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: Update jitsi-srtp to 1.1-18-g98e4c5d.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Boris Grozev <boris@jitsi.org>
…from 2.12.4 to 2.17.1 (#2166)

chore(deps): Bump com.fasterxml.jackson.module:jackson-module-kotlin

Bumps [com.fasterxml.jackson.module:jackson-module-kotlin](https://github.com/FasterXML/jackson-module-kotlin) from 2.12.4 to 2.17.1.
- [Commits](FasterXML/jackson-module-kotlin@jackson-module-kotlin-2.12.4...jackson-module-kotlin-2.17.1)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.module:jackson-module-kotlin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `kotest.version` from 5.9.0 to 5.9.1.

Updates `io.kotest:kotest-runner-junit5-jvm` from 5.9.0 to 5.9.1
- [Release notes](https://github.com/kotest/kotest/releases)
- [Commits](kotest/kotest@v5.9.0...v5.9.1)

Updates `io.kotest:kotest-assertions-core-jvm` from 5.9.0 to 5.9.1
- [Release notes](https://github.com/kotest/kotest/releases)
- [Commits](kotest/kotest@v5.9.0...v5.9.1)

Updates `io.kotest:kotest-property-jvm` from 5.9.0 to 5.9.1
- [Release notes](https://github.com/kotest/kotest/releases)
- [Commits](kotest/kotest@v5.9.0...v5.9.1)

---
updated-dependencies:
- dependency-name: io.kotest:kotest-runner-junit5-jvm
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.kotest:kotest-assertions-core-jvm
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.kotest:kotest-property-jvm
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Bumps [org.jetbrains:annotations](https://github.com/JetBrains/java-annotations) from 23.0.0 to 24.1.0.
- [Release notes](https://github.com/JetBrains/java-annotations/releases)
- [Changelog](https://github.com/JetBrains/java-annotations/blob/master/CHANGELOG.md)
- [Commits](JetBrains/java-annotations@23.0.0...24.1.0)

---
updated-dependencies:
- dependency-name: org.jetbrains:annotations
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…0.0 to 4.8.5.0 (#2169)

chore(deps): Bump com.github.spotbugs:spotbugs-maven-plugin

Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.7.0.0 to 4.8.5.0.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.7.0.0...spotbugs-maven-plugin-4.8.5.0)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…5.1 to 3.6.0 (#2170)

chore(deps): Bump org.apache.maven.plugins:maven-shade-plugin

Bumps [org.apache.maven.plugins:maven-shade-plugin](https://github.com/apache/maven-shade-plugin) from 3.5.1 to 3.6.0.
- [Release notes](https://github.com/apache/maven-shade-plugin/releases)
- [Commits](apache/maven-shade-plugin@maven-shade-plugin-3.5.1...maven-shade-plugin-3.6.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-shade-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: Add a timeline event when the packet was sent over ICE.

* feat: Add another analize-timeline script.
Moves the bitrate controller transform (applying source projection
logic) and SSRC rewriting to the sender pipeline. Previously an
RtpReceiver's pipeline was running this code for every target endpoint.

This reduces the packet processing time for large conferences since the
work is split to multiple threads.
Don't consider streams reset a "Surprising" SCTP callback.
There were reference cycles through JNI, which the garbage collector can't detect.
* chore: Update jicoco.

* fix(#2184): Revert "chore(deps): Bump jersey.version from 3.0.10 to 3.1.7 (#2145)"

Fixes issues with mismatched jetty versions reported in #2184

This reverts commit a14d491.
Otherwise the IceTransport reader job exits.
* ref: Move BufferPool setup to Main.

* ref: Remove the use-component-socket option.

The option was required, IceTransport unconditionally reads from the
component socket.

* log: Remove endpoint ID from IceMediaStream name.
* feat: Remove support for ICE/TCP.

* TURN/TLS provides a better solution for the same problem.
* The implementation has been known to have issues with threads getting blocked.
* ICE/TCP gets in the way of improvements we're currently working on.
* We (jitsi team) haven't used it in any of our deployments since at least 2018.
* See also: jitsi/docker-jitsi-meet@7a93978
Rather than processing them synchronously in the I/O thread.
VP9 flexible mode doesn't announce temporal layers in advance, so add them to the encoding desc
as they are encountered.
Bumps [io.sentry:sentry](https://github.com/getsentry/sentry-java) from 7.9.0 to 7.14.0.
- [Release notes](https://github.com/getsentry/sentry-java/releases)
- [Changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md)
- [Commits](getsentry/sentry-java@7.9.0...7.14.0)

---
updated-dependencies:
- dependency-name: io.sentry:sentry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [io.sentry:sentry](https://github.com/getsentry/sentry-java) from 7.9.0 to 7.14.0.
- [Release notes](https://github.com/getsentry/sentry-java/releases)
- [Changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md)
- [Commits](getsentry/sentry-java@7.9.0...7.14.0)

---
updated-dependencies:
- dependency-name: io.sentry:sentry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

* Don't feed SCTP packets to the SCTP stack after it's been closed.

(It results in harmless-but-scary warnings in the logs about verification tags being wrong.)

* Change an sctp log to info.
* feat: Use the ice4j push API.
* feat: Put incoming DTLS packets on a queue.
* Start writing to the ICE transport as soon as we have any validated pair.
* chore: Bump to ice4j 3.2

---------

Co-authored-by: Jonathan Lennox <jonathan.lennox@8x8.com>
* Agent should fail on SocketNotFoundException
* Don't start multiple PaceMakers for a single CheckList.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants