feat: As a Security Server Administrator I want the data exchange to account for the TSA and OCSP strategy I have selected so that I can manage cost #3120
Conversation
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 19687780807]: 🌳 CO2 Data: Total cost of whole PR so far:
|
|||||||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 19687780807]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageOnArm
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 19687780807]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 19687780807]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 19687780807]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
| }); | ||
| } | ||
|
|
||
| public List<String> sort(SystemProperties.ServicePrioritizationStrategy prioritizationStrategy) { |
There was a problem hiding this comment.
This method is also filtering, so method name is a bit misleading. Maybe filterSort or select would describe it better?
This also applies to class name.
| <documentation>Describes whether the service is free or paid</documentation> | ||
| <appinfo> | ||
| <jxb:javaType name="org.niis.xroad.globalconf.model.CostType" parseMethod="valueOf" printMethod="name"/> | ||
| <jxb:javaType name="org.niis.xroad.common.CostType" parseMethod="valueOf" printMethod="name"/> |
There was a problem hiding this comment.
This wasn't added in this PR, but bindings should go into separate file as can be seen in identifiers-bindings.xml. Schema should be implementation agnostic.
| addresses = | ||
| globalConfProvider.getOrderedOcspResponderAddresses(TestCertUtil.getCertChainCert("user_1.p12")); | ||
|
|
||
| assertEquals(5, addresses.size()); |
There was a problem hiding this comment.
These lists could be asserted better with assertj-s containsExactly
| log.debug("OCSP responder urls will be sorted based on prioritization strategy: {}", prioritizationStrategy); | ||
| return sorter.sort(prioritizationStrategy); | ||
| } else { | ||
| return responders.stream().map(SharedParameters.OcspInfo::getUrl).collect(Collectors.toList()); |
There was a problem hiding this comment.
One way to address the sonar warning on this line would be returning Stream instead of list from this method. Then in the calling mehtod, member ocsp responder could be appended with Stream.concat(..., Optional.ofNullable(uri).stream())
| }); | ||
| } | ||
|
|
||
| public List<String> sort(SystemProperties.ServicePrioritizationStrategy prioritizationStrategy) { |
There was a problem hiding this comment.
Maybe it would better to split filtering and sorting into separate methods, so they could be used directly on stream and grouping in divide() would not be necessary.
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
mikkbachmann
force-pushed
the
XRDDEV-2981
branch
from
6a98520 to
7b13fea
Compare
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
2 similar comments
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
mikkbachmann
force-pushed
the
XRDDEV-2981
branch
from
7b13fea to
f292559
Compare
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 19891889103]: 🌳 CO2 Data: Total cost of whole PR so far:
|
|||||||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 19891889103]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageOnArm
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 19891889103]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 19891889103]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 19891889103]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
mikkbachmann
force-pushed
the
XRDDEV-2981
branch
from
f292559 to
208ec08
Compare
…account for the TSA and OCSP strategy I have selected so that I can manage cost refs: XRDDEV-2981
…account for the TSA and OCSP strategy I have selected so that I can manage cost CR changes refs: XRDDEV-2981
mikkbachmann
force-pushed
the
XRDDEV-2981
branch
from
208ec08 to
379f3f8
Compare
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
|
|
Eco CI Output [RUN-ID: 19993679358]: 🌳 CO2 Data: Total cost of whole PR so far:
|
|||||||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
|
Eco CI Output [RUN-ID: 19993679358]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageOnArm
|
|
Eco CI Output [RUN-ID: 19993679358]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
|
Eco CI Output [RUN-ID: 19993679358]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
|
Eco CI Output [RUN-ID: 19993679358]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
mikkbachmann
changed the title
refs: XRDDEV-2981