sysbuild: Add support for OpenThread #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with python not be directly used to run the imgtool program to sign images Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Deprioritises the empty network core image, this is to allow the thingy53 board to always have it selected Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Fixes wrongly enabling this mode for MCUboot when it should only have been enabled by default on devices with hardware cryptocell, with some exclusions Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Changes from fatal error to warning level when issues with sysbuild multi image configuration is detected so that builds can be fixed Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds support for using the nrf9161dk target board Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
It is necessary to erase progress for both streams before test execution. Remove the bootloader from sysbuild as the bootloader is not required by the test. Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
Adds the external flash functionality from child/parent image partition manager Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Reduces the number of slots if the current image is MCUboot as this configuration is no longer stored in the application in sysbuild Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Fixes an issue of not using the correct file when building TF-M test projects Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds missing BYPRODUCT_* cache variables which are used to store the name of the signed files. Also fixes not updating the flash runner hex file for variant images Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds sysbuild configurations to samples, applications and tests which replaces child/parent image builds Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds dependencies on some image .config files so that sysbuild cmake reruns after these files have changed, to avoid stick configuration being stuck when sysbuild previously read Kconfig values Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds bluetooth mesh DFU metadata output support to app_update.zip Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Enables wifi by default in sysbuild for this board Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Excludes partition manager for all nrf54h20dk board targets Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds support for outputting matter factory data using sysbuild Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Enables factory data output for sysbuild builds Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Renames the test to avoid a conflict with an MCUboot sysbuild cmake file Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Switches to using SoCs instead of boards, this allows any nrf5340 or nrf91x-based board to make use of things like network core images and secure boot Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds initial support for loading nRF700x patches from QSPI Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds initial sysbuild options for partition layout Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Fixes an inconsistency with sysbuild's partition manager not escaping variables that child/parent image would Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Updates find-my, sidewalk and zephyr to include sysbuild support Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds a deprecation warning that describes that child/parent image has been replaced with sysbuild and when the feature will be removed entirely Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Changes from the deprecated build type to file suffix Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Changes from the deprecated build type to file suffix Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds support for generating an update zip file Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Fixes b0 signing to work for both application and network core images, and to only generate the dfu_mcuboot.zip if it is an MCUboot image. Also fixes issues with custom signing which would not use the correct public signing key and would emit a warning about using debug keys Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Added support for Matter OTA firmware update to sysbuild. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
Queitens invalid warning messages that run at wrong times from the child/parent image to sysbuild transition Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Use ncs-build image based on ubuntu 22.04. It contains gcc 11 needed for twister tests on native simulator. Signed-off-by: Jan Gałda <jan.galda@nordicsemi.no>
Removes child and parent image folders as these are no longer used Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds some child and parent image builds without sysbuild to ensure features remain working until the feature is fully removed Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Only includes dummy values for the secure boot bootloader when partition manager is disabled Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Added support for OT to sysbuild Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
maciejbaczmanski
force-pushed
the
ot_sysbuild
branch
from
873d60f to
2d23e84
Compare
nordicjm
reviewed
May 22, 2024
Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
maciejbaczmanski
force-pushed
the
ot_sysbuild
branch
from
2d23e84 to
8a525d4
Compare
|
already added to PR: nrfconnect#13153 |
wiba-nordic
suggested changes
May 22, 2024
| @@ -66,26 +66,26 @@ Complete the following steps to prepare for the certification tests: | |||
|
|
|||
| #. Build the certification image. | |||
|
|
|||
| Use the :ref:`ot_cli_sample` sample as a base, and apply the ``ci`` and ``multiprotocol`` snippets. | |||
| Use the :ref:`ot_cli_sample` sample as a base, apply the ``ci`` and ``multiprotocol`` snippets and if building for ``nrf5340dk/nrf5340/cpuapp`` target, set :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` flag. | |||
There was a problem hiding this comment.
Suggested change
| Use the :ref:`ot_cli_sample` sample as a base, apply the ``ci`` and ``multiprotocol`` snippets and if building for ``nrf5340dk/nrf5340/cpuapp`` target, set :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` flag. | |
| Use the :ref:`ot_cli_sample` sample as a base and apply the ``ci`` and ``multiprotocol`` snippets. | |
| If you are building for the ``nrf5340dk/nrf5340/cpuapp`` target, also set the :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` Kconfig option to ``y``. |
| -DCONFIG_OPENTHREAD_LIBRARY=y | ||
|
|
||
| .. note:: | ||
| The configuration option selects the precompiled OpenThread libraries. | ||
| The ``multiprotocol`` snippet enables :ref:`multiprotocol support <ug_multiprotocol_support>` with Bluetooth® LE advertising. | ||
| The ``multiprotocol`` snippet and :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` flag enable :ref:`multiprotocol support <ug_multiprotocol_support>` with Bluetooth® LE advertising. |
There was a problem hiding this comment.
Suggested change
| The ``multiprotocol`` snippet and :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` flag enable :ref:`multiprotocol support <ug_multiprotocol_support>` with Bluetooth® LE advertising. | |
| The ``multiprotocol`` snippet and the :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` Kconfig option enable :ref:`multiprotocol support <ug_multiprotocol_support>` with Bluetooth® LE advertising. |
Comment on lines
+106
to
+107
| .. note:: | ||
| When building with ``multiprotocol`` snippet, for the ``nrf5340dk/nrf5340/cpuapp`` build target, additional :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` option has to be set. |
There was a problem hiding this comment.
Suggested change
| .. note:: | |
| When building with ``multiprotocol`` snippet, for the ``nrf5340dk/nrf5340/cpuapp`` build target, additional :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` option has to be set. | |
| .. note:: | |
| When building with the ``multiprotocol`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` build target, the :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` Kconfig option has to be set to ``y``. | |
Note the empty lines before and after the note.
Comment on lines
+130
to
+131
| .. note:: | ||
| When building with ``multiprotocol_ble`` snippet, for the ``nrf5340dk/nrf5340/cpuapp`` build target, additional :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` option has to be set. |
There was a problem hiding this comment.
Suggested change
| .. note:: | |
| When building with ``multiprotocol_ble`` snippet, for the ``nrf5340dk/nrf5340/cpuapp`` build target, additional :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` option has to be set. | |
| .. note:: | |
| When building with the ``multiprotocol_ble`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` build target, the :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` Kconfig option has to be set to ``y``. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.