Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resampler library #7

Merged
merged 12 commits into from
Dec 27, 2023
Merged

Use resampler library #7

merged 12 commits into from
Dec 27, 2023

Conversation

norihiro
Copy link
Owner

@norihiro norihiro commented Dec 21, 2023

Description

Instead of adding or removing one frame, use resampler so that the added or removed frames are not noticed as a noise.

Fix #1.

How Has This Been Tested?

General checklist

  • The commit is reviewed by yourself.
  • The code is tested.
  • Document is up to date or not necessary to be changed.
  • The commit is compatible with repository's license.

@norihiro
Copy link
Owner Author

This does not work on macOS.
Version strings in the library should be omitted. Currently, otool -L shows as below.

obs-async-audio-filter.plugin/Contents/MacOS/obs-async-audio-filter (architecture x86_64):
	@rpath/libobs.framework/Versions/A/libobs (compatibility version 1.0.0, current version 28.0.0)
	@rpath/libswresample.4.3.100.dylib (compatibility version 4.0.0, current version 4.3.100)
	@rpath/libavutil.57.17.100.dylib (compatibility version 57.0.0, current version 57.17.100)

@norihiro
Copy link
Owner Author

This also does not work on Windows.
The DLL requires swresample-3.dll but OBS 30.0 provides swresample-4.dll.

@norihiro norihiro marked this pull request as draft December 26, 2023 06:46
@norihiro
Copy link
Owner Author

Relying on DLLs from OBS Studio would confuse users when they update OBS Studio.
I will re-write the implementation to use a static-linked library.

@norihiro norihiro force-pushed the use-swr branch 3 times, most recently from c1b5d4c to 847b569 Compare December 26, 2023 12:47
@norihiro norihiro force-pushed the use-swr branch 2 times, most recently from 2605e6f to e24844a Compare December 26, 2023 14:06
@norihiro norihiro marked this pull request as ready for review December 26, 2023 15:23
@norihiro norihiro changed the title Use resampler from FFmpeg Use resampler library Dec 27, 2023
@norihiro norihiro merged commit 83e98eb into main Dec 27, 2023
12 checks passed
@norihiro norihiro deleted the use-swr branch December 27, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve distortion
1 participant