fix race-condition locking up the firmware after instant-stop#26
Open
martinxyz wants to merge 1 commit intonortd:masterfrom
Open
fix race-condition locking up the firmware after instant-stop#26martinxyz wants to merge 1 commit intonortd:masterfrom
martinxyz wants to merge 1 commit intonortd:masterfrom
Conversation
When all block buffers are in use, some waiting loops store (block_buffer_head+1) before the loop starts, under the assumption that no other code can add a block to the buffer. Which is kind of correct. But if an instant-stop did happen during such a loop it got stuck there forever.
Author
|
We noticed this in our fablab. The fix was tested&verified in my pulseraster fork (https://github.com/martinxyz/LasaurApp), but since the affected firmware code in this repo looks the same I'm submitting it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all block buffers are in use, some waiting loops store (block_buffer_head+1)
before the loop starts, under the assumption that no other code can add a block
to the buffer. Which is kind of correct. But if an instant-stop did happen during
such a loop it got stuck there forever.