fix: check-line-endings command of Makefile
#499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
requested review from
gokarnm,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
Two-Hearts,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 35 35
Lines 3344 3344
=======================================
Hits 2691 2691
Misses 508 508
Partials 145 145 ☔ View full report in Codecov by Sentry. |
JeyJeyGao
changed the title
check-line-endings command of Makefile
Two-Hearts
force-pushed
the
fix/Makefile
branch
from
01b0252 to
e8cc56a
Compare
This PR improves log readability of the library. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
force-pushed
the
fix/Makefile
branch
from
60469ff to
dbc4491
Compare
Two-Hearts
added a commit
to Two-Hearts/notation-go
that referenced
this pull request
Jan 15, 2025
Fix: - update the command to search script file in `.` instead of `scripts/` folder to avoid returning an error. --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
.instead ofscripts/folder to avoid returning an error.