Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

🎁 add helpful query attributes to iiif_print_pending_relationships #656

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,6 @@ gem 'blacklight_range_limit', '6.5.0'
gem 'dog_biscuits', git: 'https://github.com/samvera-labs/dog_biscuits.git'
gem 'hyrax-v2_graph_indexer', git: 'https://github.com/scientist-softserv/hyrax-v2_graph_indexer', branch: 'main'
# rubocop:disable Metrics/LineLength
gem 'iiif_print', git: 'https://github.com/scientist-softserv/iiif_print.git', ref: '56069b5f8bbcbf6629b9973352069d21d5ddaf0f'
gem 'iiif_print', git: 'https://github.com/scientist-softserv/iiif_print.git', branch: 'add-models-to-pending-relationships-table'
Copy link
Contributor Author

@ShanaLMoore ShanaLMoore Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove the branch reference and bundle update iiif_print --conservative once the corresponding PR gets approved/merged into iiif_print.

# rubocop:enable Metrics/LineLength
gem 'order_already'
11 changes: 6 additions & 5 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,16 @@ GIT

GIT
remote: https://github.com/scientist-softserv/iiif_print.git
revision: 56069b5f8bbcbf6629b9973352069d21d5ddaf0f
ref: 56069b5f8bbcbf6629b9973352069d21d5ddaf0f
revision: 1c9daacba799bea3b125acf39c44bcfda9038b4d
branch: add-models-to-pending-relationships-table
specs:
iiif_print (1.0.0)
blacklight_iiif_search (>= 1.0, < 3.0)
blacklight_iiif_search (~> 1.0)
derivative-rodeo (~> 0.5)
hyrax (>= 2.5, < 6)
dry-monads (~> 1.4.0)
hyrax (>= 2.5, < 4)
nokogiri (>= 1.13.2)
rails (>= 5.0, < 8.0)
rails (~> 5.0)
rdf-vocab (~> 3.0)

GIT
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class AddModelDetailsToIiifPrintPendingRelationships < ActiveRecord::Migration[5.2]
def change
add_column :iiif_print_pending_relationships, :parent_model, :string
add_column :iiif_print_pending_relationships, :child_model, :string
add_column :iiif_print_pending_relationships, :file_id, :string
end
end
5 changes: 4 additions & 1 deletion db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 2023_06_08_153601) do
ActiveRecord::Schema.define(version: 2023_11_10_163052) do

# These are extensions that must be enabled in order to support this database
enable_extension "hstore"
Expand Down Expand Up @@ -377,6 +377,9 @@
t.string "child_order", null: false
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.string "parent_model"
t.string "child_model"
t.string "file_id"
t.index ["parent_id"], name: "index_iiif_print_pending_relationships_on_parent_id"
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module AdventistPagesToJpgsSplitter
#
# @see https://github.com/scientist-softserv/iiif_print/blob/a23706453f23e0f54c9d50bbf0ddf9311d82a0b9/lib/iiif_print/jobs/child_works_from_pdf_job.rb#L39-L63
def self.call(path,
splitter: DerivativeRodeoSplitter,
splitter: Rails.env.development? ? PagesToJpgsSplitter : DerivativeRodeoSplitter,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note from Jeremy:

image

suffixes: CreateDerivativesJobDecorator::NON_ARCHIVAL_PDF_SUFFIXES,
**args)
return [] if suffixes.any? { |suffix| path.downcase.end_with?(suffix) }
Expand Down