🎁 Only run thumbnail derivatives on thumbnails

[kirkkwang]

We were seeing that our thumbnail files were getting word coordinates derivatives, which is a waste of processing time. The jobs would eventually fail but ideally we don't want them to run at all for thumbnails.

This commit will override the DerivativeRodeoService and remove all other derivatives except for thumbnails if our file is a thumbnail file.

Also in this commit, we were seeing a nilClass error for a logger in development, so that has also been fixed.

Ref:

• Don't run HOCR on thumbnail files adventist_knapsack#222

[jeremyf]

I have a concern about values being deleted and having an impact.

[kirkkwang]

Ah understood, I thought each run was pretty well scoped to the file at play so it seemed like it shouldn't have side effects for the next file that comes through. I'd like to hear your thoughts.

in a different iteration i had

    def create_derivatives(filename)
      named_derivatives_and_generators.flat_map do |named_derivative, generator_name|
        return if named_derivative == :json && filename.downcase.ends_with?(Hyku::THUMBNAIL_FILE_SUFFIX)

        lasso_up_some_derivatives(
          named_derivative: named_derivative,
          generator_name: generator_name,
          filename: filename
        )
      end
    end

[jeremyf]

In that updated iteration, instead of return you should probably use next; return might leave the create_derivative function entirely.

Note, I've added notch8/iiif_print#306 which provides a configurable point instead of a decorator point.