Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🎁 Work show pg: Display Part Of as Periodical for Journal Articles (#103
) In the non knapsack app, the part of label was called "Periodical" for Journal Article work types. For the sake of consistency, the client would like to keep it this way. Issue: - https://github.com/scientist-softserv/adventist-dl/issues/658 # Screenshot  ## Notes Adventist proper had a conditional in the [attribute_rows partial](https://github.com/scientist-softserv/adventist-dl/blob/92879b9c2c8e48c410ff4c8918019f8a8fd39607/app/views/hyrax/journal_articles/_attribute_rows.html.erb#L16-L20) to change the display label. This conditional no longer exists in adventist knapsack, so the fix was to add a label.  # TODO We need to bring back a conditional label. For example, Generic Work's part of would now say Periodical. It seems as though that label should only apply to Article work types. [Staging](https://sdapi.s2.adventistdigitallibrary.org/concern/generic_works/dd57667d-7ae3-413c-a2c8-1cdd4bbebcc7?locale=en) example of Generic Work confirms this: <img width="1261" alt="image" src="https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/095826c9-883b-4344-b38c-20dbf08255b8">
- Loading branch information