🐛 Fix OAI importers #102
Merged
🐛 Fix OAI importers #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will fix the OAI importer by adjusting the `FileSetActor` and `ImportUrlJob`. The reason why it wasn't working is because it was based on Hyrax 2.9.6 method signatures which has changed in Hyrax 3.5.0. Ref: - https://github.com/scientist-softserv/adventist-dl/issues/624
kirkkwang
force-pushed
the
i624-fix-oai-importer
branch
from
51e17c9 to
d5c4d19
Compare
jeremyf
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
This commit will fix the OAI importer by adjusting the
FileSetActorandImportUrlJob. The reason why it wasn't working is because it was based on Hyrax 2.9.6 method signatures which has changed in Hyrax 3.5.0.Ref:
Expected Behavior Before Changes
Executing an OAI import would result in a
RuntimeError.Expected Behavior After Changes
Executing an OAI import should result in a successful import.
Screenshots / Video