🐛 i693 - controlled vocab location dropdown does not load #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2024 15:27
Add missing translation for based_near label. Add geonames_username configuration to hyrax initializater to match production settings. Issue - https://github.com/scientist-softserv/adventist-dl/issues/693
geonames username and password are in 1Password too.
ShanaLMoore
force-pushed
the
i693-location-dropdown
branch
from
e56458a to
9d1bee7
Compare
ShanaLMoore
commented
Feb 13, 2024
| # Location autocomplete uses geonames to search for named regions. | ||
| # Specify the user for connecting to geonames: | ||
| # Register here: http://www.geonames.org/manageaccount | ||
| config.geonames_username = ENV.fetch('HYKU_GEONAMES_USERNAME', 'jcoyne') |
There was a problem hiding this comment.
jcoyne is the username that adventist production uses. I created a new account/username but jcoyne could be used as a fallback here.
the new username/password is in 1password if anyone ever needs access to geonames.org
ShanaLMoore
changed the title
jeremyf
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing translation for based_near label. Add geonames_username configuration to hyrax initializer to match production settings.
Issue
Before this commit, the location does not load
After, the location field is a controlled vocabulary drop down with populated options.