Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update refs to use new actions location #590

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

cziaarm
Copy link
Collaborator

@cziaarm cziaarm commented Jan 14, 2025

Story

Change important references back to notch8

Expected Behavior Before Changes

No deploy (e.g. https://github.com/notch8/britishlibrary/actions/runs/12651861641)

Expected Behavior After Changes

Deploy success

ShanaLMoore
ShanaLMoore previously approved these changes Jan 14, 2025
@ShanaLMoore ShanaLMoore self-requested a review January 14, 2025 15:25
@ShanaLMoore
Copy link
Contributor

Approved, however when I do a search for scientist-softserv in this repo there are more than 5 files that need to change. Perhaps a few were missed? @cziaarm

ref: https://github.com/search?q=repo%3Anotch8%2Fbritishlibrary%20scientist-softserv&type=code

@ShanaLMoore ShanaLMoore dismissed their stale review January 14, 2025 15:27

Approved, however when I do a search for scientist-softserv in this repo there are more than 5 files that need to change. Perhaps a few were missed? ref: https://github.com/search?q=repo%3Anotch8%2Fbritishlibrary%20scientist-softserv&type=code

@cziaarm
Copy link
Collaborator Author

cziaarm commented Jan 15, 2025

Build failing at ...rake assets:precompile... line: https://github.com/notch8/britishlibrary/actions/runs/12793865846

Checked running bundle exec rake assets:precompile locally and got a seg fault :/

@ShanaLMoore
Copy link
Contributor

Build failing at ...rake assets:precompile... line: https://github.com/notch8/britishlibrary/actions/runs/12793865846

Checked running bundle exec rake assets:precompile locally and got a seg fault :/

Sorry, I totally missed this message 🙃 Let me have a look.

@ShanaLMoore
Copy link
Contributor

@cziaarm
I made a copy of your branch + additional changes here
my concern is that locally I am not able to get the project to start so please verify that you can on this branch before calling it good.
branch: switch_back_to_n8-copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants