Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #377

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix lint errors #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/jobs/iiif_print/jobs/child_works_from_pdf_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def perform(id, pdf_paths, user, admin_set_id, *)
# However, there seem to be cases where we still don't have the file when we get here, so to be sure, we
# re-do the same command that was previously used to prepare the file path. If the file is already here, it
# simply returns the path, but if not it will copy the file there, giving us one more chance to have what we need.
redownload = pdf_file_set && pdf_file_set.is_a?(ActiveFedora::Base)
redownload = pdf_file_set&.is_a?(ActiveFedora::Base)
pdf_paths = [Hyrax::WorkingDirectory.find_or_retrieve(pdf_file_set.original_file.id, pdf_file_set.id, pdf_paths.first)] if redownload
# handle each input pdf (when input is a file set, we will only have one).
pdf_paths.each do |original_pdf_path|
Expand Down
4 changes: 2 additions & 2 deletions lib/iiif_print/split_pdfs/child_work_creation_from_pdf_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ChildWorkCreationFromPdfService
#
# @return [Symbol] when we don't enqueue the job
# @return [TrueClass] when we actually enqueue the job underlying job.
# rubocop:disable Metrics/MethodLength
# rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
def self.conditionally_enqueue(file_set:, file:, user:, import_url: nil, work: nil)
work ||= IiifPrint.parent_for(file_set)

Expand All @@ -47,7 +47,7 @@ def self.conditionally_enqueue(file_set:, file:, user:, import_url: nil, work: n
)
job ? :enqueued : :pdf_job_failed_enqueue
end
# rubocop:enable Metrics/MethodLength
# rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity

##
# @api private
Expand Down
Loading