i1040 Propagate locale between group form tabs #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a UX improvement. However, it also fixes a bug where some users were getting an error message on these pages for the locale param being an empty string (`?locale=`). Strangely, this only appeared to be affecting users using Windows, but that may not be causation.
ShanaLMoore
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Ref:
This is a UX improvement. However, it also fixes a bug where some users were getting an error message on these pages for the locale param being an empty string (
?locale=). Strangely, this only appeared to be affecting users using Windows, but that may not be causation.Expected Behavior Before Changes
The
localeURL param is lost when clicking any of the tabs on the Group form. This was causing errors for some users who were somehow getting?locale=Expected Behavior After Changes
The
localeURL param is persisted when clicking any of the tabs on the Group form. Errors related tolocalebeing empty should now be impossibleScreenshots / Video