i1066 Fix member pagination on OER show pages #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pagination was attempting to act upon a local variable that didn't exist; it was removed in this commit: - fbe9093 Replace it with the presenter method that Hyrax typically uses to display member presenters
ShanaLMoore
approved these changes
Jan 13, 2025
bkiahstroud
deleted the
i1066-oers-with-many-members-throw-error-on-show-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
Story
Pagination was attempting to act upon a local variable that didn't exist; it was removed in this commit:
Replace it with the presenter method that Hyrax typically uses to display member presenters
Expected Behavior Before Changes
Viewing the show page of an OER work that has 11+ members (e.g. FileSets) throws a 500 error
Expected Behavior After Changes
OER members display in a paginated list
Screenshots / Video
Paginated members
Notes
This change needs to be contributed back to Hyku: