Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i852 Revert temporary hacks that prevent video processing #956

Merged
merged 2 commits into from
Feb 14, 2024
Merged

i852 Revert temporary hacks that prevent video processing #956

merged 2 commits into from
Feb 14, 2024

Conversation

bkiahstroud
Copy link
Contributor

@bkiahstroud bkiahstroud commented Jan 4, 2024 •
edited
Loading

ON HOLD pending these being merged:

Story

Refs

Expected Behavior Before Changes

  • mp4 and webm derivative generation for videos is skipped
  • The UV serves the raw video file

Expected Behavior After Changes

  • mp4 and webm derivative generation for videos is not skipped
  • The UV serves the video file's derivative

kirkkwang
kirkkwang approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bkiahstroud bkiahstroud mentioned this pull request Jan 9, 2024
Closed
@bkiahstroud bkiahstroud marked this pull request as ready for review February 14, 2024 01:18
@bkiahstroud bkiahstroud merged commit 2dacedf into main Feb 14, 2024
6 of 7 checks passed
@bkiahstroud bkiahstroud deleted the i852-sack-the-hack branch February 14, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkkwang kirkkwang kirkkwang approved these changes

@jeremyf jeremyf Awaiting requested review from jeremyf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkiahstroud @kirkkwang