Merge pull request #3 from notional-finance/fix-allowance

Fixing typed big number allowance
notional-finance · Oct 13, 2021 · f4632d6 · f4632d6
2 parents 0bafe72 + dd2ed3a
commit f4632d6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@notional-finance/sdk-v2",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "Notional Finance SDK V2",
   "author": "Jeff Wu <jeff@notional.finance>",
   "homepage": "https://notional.finance",

diff --git a/src/account/Account.ts b/src/account/Account.ts
@@ -184,9 +184,10 @@ export default class Account extends AccountRefresh {
     }
 
     const currency = System.getSystem().getCurrencyBySymbol(symbol);
-    const contract = currency.symbol === symbol ? currency.contract : (currency.underlyingContract as ERC20);
+    const isUnderlying = currency.underlyingSymbol === symbol;
+    const contract = isUnderlying ? currency.contract : (currency.underlyingContract as ERC20);
     const allowance = await contract.allowance(this.address, this.notionalProxy.address);
-    return TypedBigNumber.from(allowance, BigNumberType.ExternalUnderlying, symbol);
+    return TypedBigNumber.fromBalance(allowance, symbol, false);
   }
 
   /**