Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that ne_request_create() takes a target rather than a path. #126

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Clarify that ne_request_create() takes a target rather than a path. #126

merged 1 commit into from
Oct 10, 2023

Conversation

notroj
Copy link
Owner

@notroj notroj commented Oct 10, 2023 

Explicitly allow asterisk-form and absolute-form. (No functional change)

* src/ne_request.c, src/ne_request.h (ne_request_create): Change "path" parameter to "target".

* test/request.c (target_forms): Test that all three target forms generate the expected request-line.

@notroj
Clarify that ne_request_create() takes a target rather than a path.
e3b4d08 
Explicitly allow asterisk-form and absolute-form. (No functional
change)

* src/ne_request.c, src/ne_request.h (ne_request_create): Change
  "path" parameter to "target".

* test/request.c (target_forms): Test that all three target forms
  generate the expected request-line.
@notroj notroj merged commit b58acd7 into master Oct 10, 2023
192 checks passed
@notroj notroj deleted the request-target-forms branch October 10, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@notroj