Add new callback for handling interim (1xx) responses #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notroj
force-pushed
the
interim-callback
branch
2 times, most recently
from
f18637a
to
18cf23c
Compare
* src/ne_request.c (read_response_headers): Take clear argument and conditionally clear the response header hash here. (discard_headers): Remove function. (ne_add_interim_handler): New function. (send_request): Read interim response headers rather than discarding and invoke the interim handlers for each 1xx response. (ne_begin_request): No longer clear response header hash here. (ne_end_request): Don't clear response header hash here. (ne_request_destroy): Free interim handlers. * test/request.c (test_interim, interims): Add new test. * test/common/tests.h (ONCMPN): Add new macro.
single wrapper. (response_headers): Factored out from header tests. Test that reading trailers doesn't reset the main request and that merging between the two works.
notroj
force-pushed
the
interim-callback
branch
from
18cf23c
to
431929c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.