ne_uri_parse fixes #138
Merged
ne_uri_parse fixes #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notroj
reviewed
Dec 4, 2023
…th query or fragment.
* test/uri-tests.c (parse): Add test cases.
RFC 3986 3.2:
The authority component is preceded by a double slash ("//") and is
terminated by the next slash ("/"), question mark ("?"), or number
sign ("#") character, or by the end of the URI.
…prevent excessive characters from being placed in host.
* test/uri-test.c (failparse): Add test cases.
fasticc
force-pushed
the
ne-uri-parse-fixes
branch
from
10defdb
to
b1e8216
Compare
|
Brilliant. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a problem that
ne_uri_parsecan't correctly process a uri that has query or fragment, but no path. In this case, query and fragment will be placed in host.Also found that
ne_uri_parseaccepts an invalid uri that has two or more colons after host or has a port with non-digit characters.