Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally apply a timeout rather than a maximum count of interim responses #141

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Conditionally apply a timeout rather than a maximum count of interim responses #141

merged 2 commits into from
Jan 27, 2024

Commits on Jan 27, 2024

  1. Rather than appling a maximum count, apply an overall timeout to 

    reading interim responses to match the read timeout, if a read timeout
is configured and the NE_SESSFLAG_1XXTIMEOUT flag is set - which
defaults to set (issue #94):

* src/ne_session.h (NE_SESSFLAG_1XXTIMEOUT): New flag.

* src/ne_session.c (ne_session_create): Set NE_SESSFLAG_1XXTIMEOUT to
  default on.

* src/ne_request.c (send_request): Use the session read timeout to
  avoid looping reading interim responses indefinitely, rather than
  hard-coding a maximum number of responses.

* test/request.c (fail_request_with_error): Set read timeout.
  (fail_excess_1xx): Adjust expected error, send more interim
  responses.
    @notroj
    notroj committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    6f54342 View commit details
    Browse the repository at this point in the history

  2. * test/request.c (fail_excess_1xx): Try harder to timeout.

    @notroj
    notroj committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    0cffb61 View commit details
    Browse the repository at this point in the history