Simplify handling of IP literal addresses #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
notroj
commented
Jan 28, 2024
notroj
commented
use the bracketed syntax; avoid name resolution for all literal addresses. * src/ne_session.h: Clarify host parameter must match RFC 3986 syntax. * src/ne_private.h (struct host_info): Add literal field. * src/ne_session.c (free_hostinfo): Free literal field. (set_hostinfo): Parse and store IP literals including bracketed IPv6-literal. (ne_session_create) Use literal field to determine TLS SNI mode. * test/utils.c (session_server): Use bracketed IPv6 literals. * test/request.c (ipv6_host_checker, serve_v6_check, ipv6_literal): Test for bracketed form of IPv6 literals. * src/ne_request.c (do_connect): Update comment.
notroj
force-pushed
the
ipv6-literals
branch
2 times, most recently
from
0d9ce52
to
f4187c9
Compare
* test/utils.c (session_server): Store the hostname. (get_session_host): New function. * test/request.c (status, status_chunked): Use get_session_host() to accurately create the expected status notifier output.
notroj
force-pushed
the
ipv6-literals
branch
2 times, most recently
from
7b7ee9d
to
9dcf8a3
Compare
matching a DNS name against an IP address, and remove URI altname support since this is not specified by RFC 9110/6125. * src/ne_openssl.c (check_identity): Take the host_info rather than a URI; only test DNS names for a non-literal identifier, and only test IP addresses for a literal identifier. (check_certificate): Adjust accordingly. * src/ne_gnutls.c (check_identity, check_certificate): Update similarly. * src/ne_session.c (ne__ssl_match_hostname): Drop now unnecessary safety check for IP addresses here. * test/ssl.c (uri_altname, fail_bad_urialtname): Removed tests. (fail_ssl_request_with_error2): Update to use fakeproxied_session_server. (cert_identities): Drop altname8.cert (URI altname). * test/makekeys.sh, test/openssl.conf: Drop URI altname cert generation.
notroj
force-pushed
the
ipv6-literals
branch
2 times, most recently
from
881c56b
to
9fbf570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.