Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Bunch of changes #51

Merged
merged 7 commits into from
Jan 2, 2024
Merged

Update: Bunch of changes #51

merged 7 commits into from
Jan 2, 2024

Conversation

notsatan
Copy link
Owner

@notsatan notsatan commented Jan 2, 2024

Bunch of minor changes, and some house-hold chores

  • Update the black revision used for pre-commit
  • Bump the version of Go offered as choices: 1.21, ,1.20 and 1.19
  • Updates to the linter workflow to accommodate upstream changes
  • New ignore rules for generated projects, ensures ignoring secret/session files

Type of Change

  • 📚 Documentation (Non-breaking change; Changes in the documentation)
  • 🔧 Bug fix (Non-breaking change; Fixes an existing bug)
  • 🥂 Improvement (Non-breaking change; Improves existing feature)
  • 🚀 New feature (Non-breaking change; Adds functionality)
  • 🔐 Security fix (Non-breaking change; Patches a security issue)
  • 💥 Breaking change (Breaks existing functionality)

Review Process

Reviewees:

  1. Prefer incremental and appropriately-scoped changes.
  2. Leave a comment on things you want explicit feedback on.
  3. Respond clearly to comments and questions.

Reviewers:

  1. Test functionality using the criteria above.
  2. Offer tips for efficiency, feedback on best practices, and possible alternative approaches.
  3. For shorter, "quick" PRs, use your best judgment on the previous point.
  4. Use a collaborative approach and provide resources and/or context where appropriate.
  5. Provide screenshots/grabs where appropriate to show findings during review.
  6. In case of a potential bug in PR, be sure to add steps to reproduce the issue (where applicable)

@notsatan
Update: Bump black revision used for pre-commit
24cac54 
Signed-off-by: notsatan <git@notsatan.me>
@notsatan
Minor: Trim trailing whitespaces
9e523c4 
Signed-off-by: notsatan <git@notsatan.me>
@notsatan
Update: Bump Go version choices for generated templates
8b57b5d 
This commit bumps the Go version(s) offered as a choice, the newer
versions include — 1.21, 1.20 and 1.19

Signed-off-by: notsatan <git@notsatan.me>
@notsatan
Update: Changes to the linter workflow
19d00ed 
The `golangci-lint` Github action had some changes since the last
version — including the fact that the action stopped setting up
Go on the workflow environment

This commit primarily adds a new step to setup Go on the runner

Signed-off-by: notsatan <git@notsatan.me>
@notsatan
Minor: Changes to dockerfile for generated templates
254153c 
Signed-off-by: notsatan <git@notsatan.me>
@notsatan
Minor: Update ignore rules for .gitignore
3fdc588 
This update ensures generated projects will ignore secret files and
the likes from git, by default

Signed-off-by: notsatan <git@notsatan.me>
@notsatan notsatan self-assigned this Jan 2, 2024
@notsatan
Minor: Changes to generated README
2233531 
The generated README mentioned `Bandit` instead of `GoSec` on the
badge label — something that got carried over from Python

Signed-off-by: notsatan <git@notsatan.me>
@notsatan notsatan merged commit 3933e93 into master Jan 2, 2024
3 checks passed
@notsatan notsatan deleted the feature/upgrade branch January 2, 2024 01:29
@notsatan notsatan mentioned this pull request Jan 2, 2024
Closed
@notsatan notsatan linked an issue Jan 2, 2024 that may be closed by this pull request
Feature: Add support for Go versions beyond 1.18 #49
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notsatan notsatan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add support for Go versions beyond 1.18
1 participant
@notsatan