Redeem flow #1787
Merged
Redeem flow #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonijzelinskij
approved these changes
Jan 31, 2025
Comment on lines
+64
to
+69
| override fun finishRedeemFlow(redeemConsequences: RedeemConsequences) { | ||
| if (redeemConsequences.willKillStash) { | ||
| stakingDashboardRouter.returnToStakingDashboard() | ||
| } else { | ||
| returnToStakingMain() | ||
| } |
There was a problem hiding this comment.
I think it would be better to provide a boolean flag here instead of domain model
There was a problem hiding this comment.
Yeah the typelias to boolean seems to be a better fit, but it is not a new model and was used already in similar redeem flows so I just reused that
| <fragment | ||
| android:id="@+id/mythosRedeemFragment" | ||
| android:name="io.novafoundation.nova.feature_staking_impl.presentation.mythos.redeem.MythosRedeemFragment" | ||
| android:label="MythosRedeemFragment" /> | ||
| </navigation> |
There was a problem hiding this comment.
Let's organize a navigation graph to not mix includes, actions and fragments.
I suggest this approach: includes first, than actions and then fragments
Base automatically changed from
myth_staking/unbonding_widget
to
myth_staking_base
February 10, 2025 09:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.