Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update update android screen copy #2276

Merged
merged 1 commit into from
Jan 10, 2024
Merged

feat: update update android screen copy #2276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...hecks/osversion/ErrorWrongUpdateScreen.kt → ...ecks/osversion/OutdatedOsVersionScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import io.parity.signer.ui.theme.pink500
import io.parity.signer.ui.theme.textTertiary

@Composable
fun WrongOsVersionNotificationScreen(
fun OutdatedOsVersionScreen(
exposedVulnarabilities: List<KnownOSIssue>,
onProceed: Callback
) {
Expand Down Expand Up @@ -101,7 +101,7 @@ fun WrongOsVersionNotificationScreen(
private fun WrongOsVersionNotificationScreenPreview() {
Box(modifier = Modifier.fillMaxSize()) {
SignerNewTheme() {
WrongOsVersionNotificationScreen(
OutdatedOsVersionScreen(
listOf(KnownOSIssue.CVE_2022_20465),
onProceed = {},
)
Expand Down
4 changes: 2 additions & 2 deletions android/src/main/java/io/parity/signer/screens/initial/firstTimeOnly/FirstTimeOnly.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import androidx.navigation.NavGraphBuilder
import androidx.navigation.NavHostController
import androidx.navigation.compose.composable
import androidx.navigation.navigation
import io.parity.signer.screens.initial.eachstartchecks.osversion.WrongOsVersionNotificationScreen
import io.parity.signer.screens.initial.eachstartchecks.osversion.OutdatedOsVersionScreen
import io.parity.signer.screens.initial.eachstartchecks.osversion.OutdatedOsVersionViewModel
import io.parity.signer.screens.initial.termsconsent.TermsConsentScreenFull
import io.parity.signer.ui.rootnavigation.MainGraphRoutes
Expand All @@ -22,7 +22,7 @@ fun NavGraphBuilder.firstTimeOnlyOnboarding(
composable(route = FirstTimeOnboarding.osVersionNotification) {
val osVersionVM: OutdatedOsVersionViewModel = viewModel()
if (osVersionVM.isShouldShow()) {
WrongOsVersionNotificationScreen(
OutdatedOsVersionScreen(
exposedVulnarabilities = osVersionVM.getVulnerabilities(),
onProceed = {
navController.navigate(FirstTimeOnboarding.termsConsentRoute) {
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@
<string name="add_derived_keys_screen_cta">Confirm and Add Keys</string>
<string name="add_derived_keys_screen_alert_title">Confirm by entering the PIN code</string>
<string name="add_derived_keys_screen_alert_content">To finalize the addition of keys to the key set, please confirm that you have scanned the QR code back into the app by entering the PIN code.</string>
<string name="initial_screen_outdated_os_title">Consider updating operation system before using vault</string>
<string name="initial_screen_outdated_os_title">Please update your operation system for higher security</string>
<string name="initial_screen_outdated_os_description">Current Android version missing important security updated, exposed to at least: %1$s. It is recommended to install vault on up to date android version.</string>

</resources>
Expand Down
Loading