-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace non-sense error messages on Android #2396
base: master
Are you sure you want to change the base?
Conversation
2f88629
to
dac48b6
Compare
dac48b6
to
57b4f4d
Compare
@Dmitry-Borodin I think it is fairly clear that this is a non-sense message. Anything else you would need for a review? |
@valentunn @stepanLav @kogeler @antonkhvorov Any update on when maintenance of the repo will be picked up again? |
Oh funny, I can approve, but it does nothing. |
@Dmitry-Borodin Then what do we have to do that something is done? Was Novasama not awarded treasury funding to continue this project? |
I don't know, I don't work for Novasama. I think it's better to contact them directly. |
57b4f4d
to
afb9dbe
Compare
Rebased it and contacted Novasama again in the hope to get this finally merged. Looks like CI has some permission issues for externally hosted PRs, not much I can do about that. |
Purpose
Noticed some odd error messages in the signer, fixed them to be a lot less confusing.
Scope
Only updates three of the strings used inside the Android app.