Designate $options arg as being optional #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonjour :)
Currently code like:
causes the IDE to warn that the required second arg is missing, however reflection indicates that
tideways_enable()
(version 4.1.2) has no required args:I'm not sure if the default value is empty array or null, as it appears reflection can't provide that info: https://bugs.php.net/bug.php?id=50798, but practically I don't think it will matter.
It would also be great if you could release a stable version on packagist, at the moment this library is tagged as
dev-master
. My understanding is to release astable
version you need to add a a git tag.