Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent dir listing for more restricted deployment environment #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsingakbar
Copy link

@tsingakbar tsingakbar commented Dec 1, 2022

background

http.FileServer used by golang implemtation will list directory content when the request path is a directory.
we deploy novnc for internal usage, but the deploy enviroment is equiped with lots of security restrictions, and dir-listing is not allowed for that.
The PR will 403 Forbidden directory listing http request.

@CendioOssman
Copy link
Member

I'm afraid some user will want to be able to list files, so this would have to be an optional feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants