Use the cancellation token to properly cancel the UdpClient.ReceiveAsync() task#282
Open
andre-slashwhy wants to merge 2 commits intonovotnyllc:mainfrom
Open
Conversation
Author
|
Hi @clairernovotny, what do you think about this change? It would really help us get rid of the socket exceptions (see #281 (comment)). I'd appreciate it if you could take a look at the merge request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the cancellation token to properly cancel the UdpClient.ReceiveAsync(CancellationToken cancellationToken) task
Zeroconf/Zeroconf/NetworkInterface.cs
Line 133 in bd4bd55
Solves this issue: #281 (comment)