fix: separate v1 and v2 subscribers apis #777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jainpawan21
commented
Feb 20, 2025
jainpawan21
commented
- order of events api
- separate subscribers v1 and v2 apis
✅ Deploy Preview for docs-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scopsy
reviewed
Feb 20, 2025
| "subscribers-controller_update-subscriber-preferences", | ||
|
|
||
| "---Subscribers v1 ---", | ||
| "..." |
There was a problem hiding this comment.
Let's maybe only include functionality that is not available in v2? For example credentials, and remove all the others like like create, path, get, etc...
There was a problem hiding this comment.
so we should not have separate sections for v2 and v1? as api response could be different in v1 and v2.
There was a problem hiding this comment.
Let's try to only add the relevant endpoints that are missing in v2, under a single subscribers section and see how this looks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.