feat: ignore EACCES on linking

lib/link-gently.js

@@ -6,10 +6,16 @@
 
 const { resolve, dirname } = require('path')
 const { lstat, mkdir, readlink, rm, symlink } = require('fs/promises')
-const throwNonEnoent = er => {
-  if (er.code !== 'ENOENT') {
-    throw er
+const { log } = require('proc-log')
+const throwSignificant = er => {
+  if (er.code === 'ENOENT') {
+    return
   }
+  if (er.code === 'EACCES') {
+    log.warn('error adding file', er.message)
+    return
+  }
+  throw er
 }
 
 const rmOpts = {
@@ -37,8 +43,8 @@ const linkGently = async ({ path, to, from, absFrom, force }) => {
   // or at least a warning, but npm has always behaved this
   // way in the past, so it'd be a breaking change
   return Promise.all([
-    lstat(absFrom).catch(throwNonEnoent),
-    lstat(to).catch(throwNonEnoent),
+    lstat(absFrom).catch(throwSignificant),
+    lstat(to).catch(throwSignificant),
   ]).then(([stFrom, stTo]) => {
     // not present in package, skip it
     if (!stFrom) {

test/link-gently.js

@@ -1,6 +1,7 @@
 const t = require('tap')
 const linkGently = require('../lib/link-gently.js')
 const fs = require('fs')
+const fsp = require('fs/promises')
 const requireInject = require('require-inject')
 
 t.test('make links gently', async t => {
@@ -87,6 +88,48 @@ t.test('make links gently', async t => {
   linkGently.resetSeen()
 })
 
+t.test('handles link errors', async t => {
+  const dir = t.testdir({
+    pkg: {
+      'hello.js': `#!/usr/bin/env node\nconsole.log('hello')`,
+    },
+  })
+  const fspMock = {
+    ...fsp,
+    lstat: (ref) => {
+      const code = (/\/(e\w+)$/.exec(ref) || [])[1]
+      if (code) {
+        return Promise.reject(Object.assign(new Error(), { code: code.toUpperCase() }))
+      }
+
+      return fsp.lstat(ref)
+    },
+  }
+  const mockedLinkGently = requireInject('../lib/link-gently.js', {
+    'fs/promises': fspMock,
+  })
+  await mockedLinkGently({
+    path: `${dir}/pkg`,
+    to: `${dir}/bin/eacces`,
+    from: `../pkg/hello.js`,
+    absFrom: `${dir}/pkg/hello.js`,
+  })
+
+  await mockedLinkGently({
+    path: `${dir}/pkg`,
+    to: `${dir}/bin/enoent`,
+    from: `../pkg/hello.js`,
+    absFrom: `${dir}/pkg/hello.js`,
+  })
+
+  await t.rejects(mockedLinkGently({
+    path: `${dir}/pkg`,
+    to: `${dir}/bin/eperm`,
+    from: `../pkg/hello.js`,
+    absFrom: `${dir}/pkg/hello.js`,
+  }), { code: 'EPERM' })
+})
+
 t.test('racey race', async t => {
   const fsMock = {
     ...fs,