fix: don't go into global mode if aliased to npmg #7842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: npm will no longer switch to global mode if aliased to "npmg" or "npm-g" etc.
reggi
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: npm will no longer switch to global mode if aliased to "npmg" or "npm-g" etc.
This code is a remnant from when npm defined
binentries for itself that includednpm_gandnpm-g.npm no longer defines these, and this code should have been removed when those entries were removed. To utilize this today one would have to manually alias npm themselves.
What this code does today in practice is make local development very tricky, because if you (like me) use git worktrees, and have a worktree directory that ends in "g", npm will be in global mode when you invoke it as
node .. This is very "magical" behavior and not at all intuitive.It's best if this just goes away.
npm -gis explicit and does not require npm trying to guess if you really wanted to be in global mode or not.