Scoped packages

[jbeard4]

Attempt to resolve issue #271
All tests pass, and includes additional tests for publishing scoped modules.

[jbeard4]

I see some of the tests I wrote in 02a-publish-scoped.js are failing for travis. I will investigate this.

[iamchrismiller]

@jbeard4 Any luck tracing those failing tests? I have hit this blocker for scoped packages as well. If you don't have time I can take a look at it.

[jbeard4]

I haven't investigated why these tests are failing on Travis. They pass on my local. You can pull my branch and try it. If you have time, please feel free to investigate why these tests are failing on travis.

[IgnacioHR]

Hi,

Thank you for this patch. I was also suffering from #271 and came to the same conclusion as you.

After a quick review on the patch code I think the problem with Travis is that after the patch, you can ONLY store scoped packages and will no longer store no scoped package because of no match of the regex expression.

Unfortunately, I'm not experienced enough on Javascript to propose al alternative patch but at least I can give you short approach in pseudo code that someone can understand and translate to proper javascript

  var f = t.match(/(@[^\/]+\/)?[^\/]+$/)[0]
  var scoped = f != null  // check if f matched and set scoped var to either true or false
  if !scoped then // if not scoped, fallback to previous regular expression
    var f = t.match(/[^\/]+$/)[0]

later, near line 118

var tf = scoped ? 
   [doc.name.replace('/','%2f'), '-', f.replace('/','%2f')] : 
   [doc.name, '-', t.split('/').pop()]

[jbeard4]

Hi @IgnacioHR, upon further inspection, I found I needed to add an admin user to couch before running tests to publish scoped packages. All tests now pass in Travis, including those for non-scoped packages.
I think this PR could now be merged.

Thank you.

[jbeard4]

I'm not sure why, but the last travis build ran tests against node versions 0.10, 0.12, iojs, 4 and 5, and failed for verisons 0.10, 0.12, and iojs (but passed for verions 4 and 5). The node versions that failed are very old and no longer supported. I'm not sure why travis ran the tests against these old versions, as the previous build ran tests against node versions 4, 6, and 7, which are listed in the project's .travis.yml configuration file.

[jbeard4]

Upon further inspection, I see that the .travis.yml file was updated in master in commit 5e12d6a, so that the nodejs versions reverted to an older version. Maybe travis is using .travis.yml file from master, rather than the .travis.yml file from my branch.

[jbeard4]

Fixed travis build for node versions iojs, 0.12, 0.10 by pegging tap to version 10.7.3, which is the last version of tap supported by these older versions of node. This PR should now be OK to merge.

@watilde would it be possible to review this PR? Thank you.

[watilde]

This looks fine, but can we just use encodeURIComponent instead of regex?

[jbeard4]

This will also uri-encode the "@" as "%40". So, for example, the saved tarball for package name "@scoped/package@0.2.3-alpha" will be available at path "%40scoped%2Fpackage/-/%40scoped%2Fpackage-0.2.3-alpha.tgz", rather than "@Scoped%2Fpackage/-/@Scoped%2Fpackage-0.2.3-alpha.tgz"

I need to check if this maintains compatibility with the npm client.

[watilde]

Looks basically good to me, thanks. // but I'm not a committer

[jbeard4]

Thanks for the review.

[IgnacioHR]

After installing this version I could successfully run npm install. But now, I get error 404 when trying to do npm update on the same project where npm install worked. Any idea? The log says

742 http fetch GET 304 http://{serveraddress}.com:5984/registry/_design/app/_rewrite/@mycompany%2fmypackage 103ms (from cache)
743 http fetch GET 404 http://{serveraddress}.com:5984/@mycompany%2fmypackage/-/@mycompany%2fmypackage-1.0.0.tgz 7ms
744 silly fetchPackageMetaData error for @mycompany/mypackage@1.0.0 404 Object Not Found: @mycompany/mypackage@1.0.0

it looks like "_design/app/_rewrite/" is missing in the URL requested by the command.

[jbeard4]

@IgnacioHR I'll take a look