-
Notifications
You must be signed in to change notification settings - Fork 68
[nrf toup][crypto] Add define to enable x509 usage #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In some cases, we do not want to use x509 for Matter purposes, but it can be used for different use cases. In order to allow doing that and reducing the Matter footprint added the chip_crypto_use_x509 define that can control when the X509-related functions are added to the compilation. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
072ecfc to
802a766
Compare
802a766 to
62d12a4
Compare
62d12a4 to
db106c9
Compare
| protocol. | ||
|
|
||
| config CHIP_CRYPTO_USE_X509 | ||
| bool "MbedTLS X.509 certificate support" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to mention MbedTLS or rather say "x.509 certificate support" and instead do depends MBEDTLS or CHIP_CRYPTO_MBEDTLS (not sure which if any is correct)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but I will leave the default y if MBEDTLS_X509_LIBRARY instead of MBEDTLS
Added the CHIP_CRYPTO_USE_X509 kconfig option to enable or disable the x509 certificate processing for nrfconnect devices. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
db106c9 to
73307ce
Compare
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-connectedhomeip#679 Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-connectedhomeip#679 Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
Summary
Added the CHIP_CRYPTO_USE_X509 kconfig option to enable or disable the x509 certificate processing for nrfconnect devices.
In some cases, we do not want to use x509 for Matter purposes, but it can be used for different use cases. In order to allow doing that and reducing the Matter footprint added the chip_crypto_use_x509 define that can control when the X509-related functions are added to the compilation.
Testing
In nrf-sdk