-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace fromlists with proper fromtree commits #395
Open
de-nordic
wants to merge
15
commits into
nrfconnect:main
Choose a base branch
from
de-nordic:fromlists-to-fromtrees
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalek-no
approved these changes
Jan 9, 2025
nvlsianpu
approved these changes
Jan 16, 2025
This reverts commit 42a79a4. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
This reverts commit 38c662b. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
This reverts commit fe61522. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
This reverts commit 9c2a359. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
This reverts commit 0f60b02. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
This reverts commit c79d930. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
This reverts commit 8d844df. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
This reverts commit 3c762c1. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
The adds support for hashing image with SHA512, to allow SHA512-ED25519-SHA512 signature. To support above --sha parameter has been added that can take value: auto, 256, 384, 512 to select sha, where auto brings the default behaviour, or current, behaviour. The sha provided here is tested against key so not all combinations are supported. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no> (cherry picked from commit c894d04)
Adds LZMA2 compression to imgtool. Python lzma library is unable to compress with proper parameters while using "ALONE" container, therefore 2 header bytes are calculated and added to payload by imgtool. Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no> (cherry picked from commit 63fa7e4) Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Adds ARM thumb filter to imgtool's LZMA2 compression. Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no> (cherry picked from commit d69933c) Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
fixing broken encryption caused by shift in function parameters. Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no> (cherry picked from commit 33de65c) Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
passing user_sha parameters while creating compressed image Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no> (cherry picked from commit 15909d6) Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no> (cherry picked from commit 1c04eac60b3bc2552023d9276850d19d5f343ea1) Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
The commit adds SIG_PURE TLV that should be used as TLV indicating that the signature attached to image has been calculated over entire image, rather than digest of image. This is generic flag as the "pure" usage may be applied to, potentially, any signature algorithm. (cherry picked from commit 30bcd46) (cherry picked from commit 7e01086) (cherry picked from commit 3d2808d) (cherry picked from commit 42a79a4) Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
force-pushed
the
fromlists-to-fromtrees
branch
from
January 23, 2025 16:39
9ff55cb
to
331c4fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR attempts to remove remaining fromlists that have already become fromtree.
Note that diff with ncs/main, at the base of the PR is not zero as some of fromlists have changed before being merged.